Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tracing #37

Merged
merged 3 commits into from
Jan 11, 2025
Merged

fix: add tracing #37

merged 3 commits into from
Jan 11, 2025

Conversation

alireza13811
Copy link
Contributor

No description provided.

AlirezaEiji191379
AlirezaEiji191379 approved these changes Jan 9, 2025
View reviewed changes
Directory.Packages.props Show resolved Hide resolved
AlirezaEiji191379

This comment was marked as resolved.

Sign in to view

@alireza13811 alireza13811 requested review from AlirezaEiji191379 and removed request for AlirezaEiji191379 January 11, 2025 06:47
mostmand
mostmand approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@mostmand mostmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شاید استاتیک باشه و از DI برای TraceInstrumentation استفاده نشه بهتر باشه چون چیزی بهمون اضافه نمی‌کنه

@alireza13811 alireza13811 merged commit 40ef53b into master Jan 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostmand mostmand mostmand approved these changes

@AlirezaEiji191379 AlirezaEiji191379 AlirezaEiji191379 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alireza13811 @mostmand @AlirezaEiji191379 @alirezasamimi